JS Code Quality Optimization

if (x === "a" || x === "b" || x === "c") {
}

// Optimized
if (["a", "b", "c"].includes(x)) {
}

// When there is an if..else with minimal logic inside, it's a good shortcut.
let a = null;
if (x > 1) {
  a = true;
} else {
  a = false;
}

// Optimized
const a = x > 1 ? true : false;
// or
const a = x > 1;

const config = { a: 1, b: 2 };
const a = config.a;
const b = config.b;

// Optimized
const { a, b } = config;

const fc = (name) => {
  const breweryName = name || "default";
};

// Optimized
const fc = (name = "default") => {
  const breweryName = name;
};

function fc(currPage, totalPage) {
  if (currPage <= 0) {
    currPage = 0;
    jump(currPage); // jump
  } else if (currPage >= totalPage) {
    currPage = totalPage;
    jump(currPage); // jump
  } else {
    jump(currPage); // jump
  }
}

// Optimized
const fc = (currPage, totalPage) => {
  if (currPage <= 0) {
    currPage = 0;
  } else if (currPage >= totalPage) {
    currPage = totalPage;
  }
  jump(currPage); // separate jump function
};

let a;
if (b !== null || b !== undefined || b !== "") {
  a = b;
} else {
  a = "other";
}

// Optimized
const a = b || "other";

let a;
if (b !== null || b !== undefined) {
  a = b;
} else {
  a = "other";
}

// Optimized
const a = b ?? "other";

if (test1) {
  callMethod(); // call method
}

// Optimized
test1 && callMethod();

function checkReturn() {
  if (!(test === undefined)) {
    return test;
  } else {
    return callMe("test");
  }
}

// Optimized
const checkReturn = () => test || callMe("test");

let test = 1;
if (test == 1) {
  fc1();
} else {
  fc2();
}

// Optimized
(test === 1 ? fc1 : fc2)();

switch (index) {
  case 1:
    fc1();
    break;
  case 2:
    fc2();
    break;
  case 3:
    fc3();
    break;
  // etc...
}

// Optimized
const fcs = {
  1: fc1,
  2: fc2,
  3: fc3
};
fcs[index]();

const data = [
  {
    name: "abc",
    type: "test1"
  },
  {
    name: "cde",
    type: "test2"
  }
];

let findData;
for (const item of data) {
  if (item.type === "test1") {
    findData = item;
  }
}

// Optimized
const findData = data.find((item) => item.type === "test1");

let test = "";
for (let i = 0; i < 5; i++) {
  test += "test ";
}

// Optimized
"test ".repeat(5);

// Optimized
const a = [76, 3, 663, 6, 4, 4, 5, 234, 5, 24, 5, 7, 8];
console.log(Math.max(...a));
console.log(Math.min(...a));